Change in vdsm[master]: http protocol detection

nsoffer at redhat.com nsoffer at redhat.com
Wed May 28 06:48:09 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: http protocol detection
......................................................................


Patch Set 2:

(1 comment)

This will be very nice when implemented.

http://gerrit.ovirt.org/#/c/27839/2/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:

Line 220:     def stop(self):
Line 221:         if self.xmlBinding:
Line 222:             self.xmlBinding.stop()
Line 223: 
Line 224: 
To complete this:

- Move detector to BindingXMLRPC, which is currently the server used also for http
- Fix the logger name after the move- Create this detector with the xmlbindings, just like the XMLDetector.
- Implment handleSocket

In a future patch we should create another server for the http.

This is critical since without this this patch will break storage http flows like uploading/downloading images.
Line 225: class _HttpDetector():
Line 226:     log = logging.getLogger("protocolDetector.XmlDetector")
Line 227:     name = "http"
Line 228: 


-- 
To view, visit http://gerrit.ovirt.org/27839
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f899cbab4d95ebd184bf32f3ccec1f4fa0e49bc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list