Change in vdsm[master]: json-rpc: Protocol detection

nsoffer at redhat.com nsoffer at redhat.com
Wed May 28 06:33:00 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: json-rpc: Protocol detection
......................................................................


Patch Set 24:

(1 comment)

http://gerrit.ovirt.org/#/c/26300/24/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 148:                 else:
Line 149:                     cls._instance = clientIF(irs, log)
Line 150:         return cls._instance
Line 151: 
Line 152:     def _prepareProtocolDetecton(self):
> To be honest this is the way it was designed. I am not arguing whether it w
ok
Line 153:         host = config.get('addresses', 'management_ip')
Line 154:         port = config.getint('addresses', 'management_port')
Line 155:         sslctx = None
Line 156:         if config.getboolean('vars', 'ssl'):


-- 
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list