Change in vdsm[master]: json-rpc: Protocol detection

nsoffer at redhat.com nsoffer at redhat.com
Wed May 28 05:57:06 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: json-rpc: Protocol detection
......................................................................


Patch Set 24:

(1 comment)

Waiting for the next version

http://gerrit.ovirt.org/#/c/26300/24/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 219:             if not self._enabled:
Line 220:                 self.log.debug('cannot run prepareForShutdown twice')
Line 221:                 return errCode['unavail']
Line 222: 
Line 223:             self.acceptor.stop()
> It is exactly as suggested. We need to stop it somewhere and this is the pl
My comment was very wrong. I was interrupted while writing it and forgot to fix it later. Sorry for the noise.
Line 224:             self.xmlDetector.stop()
Line 225:             self.stompDetector.stop()
Line 226: 
Line 227:             self._enabled = False


-- 
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list