Change in vdsm[master]: tests: fix wrong use of assertions

nsoffer at redhat.com nsoffer at redhat.com
Tue May 27 22:54:00 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tests: fix wrong use of assertions
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/28124/5/tests/functional/storageTests.py
File tests/functional/storageTests.py:

Line 529:     runCommand(_exportfs.cmd, '-u', '127.0.0.1:%s' % path)
Line 530: 
Line 531: 
Line 532: def listNFS():
Line 533:     return runCommand([_exportfs.cmd])
This will fail because you send a list.
Line 534: 
Line 535: 
Line 536: def cleanNFSLeftovers(pathPrefix):
Line 537:     pathPattern = pathPrefix + "*"


Line 542:             try:
Line 543:                 unexportNFS(export)
Line 544:             except TestRunnerError as e:
Line 545:                 logging.warning("Failed to unexport NFS entry %s: %s",
Line 546:                                 export, e, exc_info=True)
logging.exception is better here.
Line 547:             else:
Line 548:                 shutil.rmtree(export, ignore_errors=True)
Line 549: 
Line 550: 


-- 
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list