Change in vdsm[master]: core: introducing uploadImageToStream

Federico Simoncelli fsimonce at redhat.com
Tue May 27 21:42:36 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: core: introducing uploadImageToStream
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/26741/10/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:

Line 119:             HEADER_VOLUME = 'Volume-Id'
Line 120:             HEADER_TASK_ID = 'Task-Id'
Line 121:             HEADER_CODE = 'Status-Code'
Line 122:             HEADER_MESSAGE = 'Status-Message'
Line 123:             HEADER_SIZE = 'Size'
This should be "Range" to be coherent with HTTP.
Line 124:             HEADER_CONTENT_LENGTH = 'content-length'
Line 125:             HEADER_CONTENT_TYPE = 'content-type'
Line 126: 
Line 127:             class RequestException():


-- 
To view, visit http://gerrit.ovirt.org/26741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2df4d3a16f39bf80281d7669ed31fd8369bada5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list