Change in vdsm[master]: json-rpc: Protocol detection

nsoffer at redhat.com nsoffer at redhat.com
Tue May 27 20:14:38 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: json-rpc: Protocol detection
......................................................................


Patch Set 24:

(1 comment)

http://gerrit.ovirt.org/#/c/26300/24/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:

Line 11: #
Line 12: # You should have received a copy of the GNU General Public
Line 13: # License along with this program; if not, write to the Free Software
Line 14: # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
Line 15: 
General naming issue for later - the naming can be simplfied by naming this module "stomp", and the classes to Reactor, Detector etc.

User code will do:

    import stomp

    sr = stomp.Reactor()
    
Much nicer than the Java like repetition:

    import stompReactor

    sr = stompReactor.StompReactor()

Or the namspace polution:

    from stompReactor import StompRactor
Line 16: import asyncore
Line 17: import os
Line 18: import threading
Line 19: import logging


-- 
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list