Change in vdsm[master]: Sign sanlock not configured when service down and stop recon...

Alon Bar-Lev alonbl at redhat.com
Tue May 27 14:24:24 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: Sign sanlock not configured when service down and stop reconfigure of force
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28007/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 193: 
Line 194:         return configured
Line 195: 
Line 196:     def reconfigureOnForce(self):
Line 197:         return False
> but it is called "reconfigure on force" so with --force it will always reco
this is:

 override = args.force and c.reconfigureOnForce()

so we want to return True to allow reconfigure at force.
Line 198: 
Line 199: 
Line 200: __configurers = (
Line 201:     LibvirtModuleConfigure(),


-- 
To view, visit http://gerrit.ovirt.org/28007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list