Change in vdsm[master]: core: BindingXMLRPC - exporting logic out from do_PUT.

nsoffer at redhat.com nsoffer at redhat.com
Tue May 27 10:48:48 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: core: BindingXMLRPC - exporting logic out from do_PUT.
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

There is one issue with _getIntHeader implementation.

http://gerrit.ovirt.org/#/c/26740/10/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:

Line 199:             def _waitForEvent(event):
Line 200:                 while not event.is_set():
Line 201:                     event.wait()
Line 202: 
Line 203:             def _getIntHeader(self, headerName, missingError):
I don't like passing the error code for the exception here. Waiting for Federico review about this.
Line 204:                 value = self.headers.getheader(
Line 205:                     headerName)
Line 206:                 if not value:
Line 207:                     raise self.RequestException(


-- 
To view, visit http://gerrit.ovirt.org/26740
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64bb1b0a4cb85ce822929f1907847dd63eb69fc2
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list