Change in vdsm[master]: tests: fix wrong use of assertions

ykleinbe at redhat.com ykleinbe at redhat.com
Tue May 27 08:13:28 UTC 2014


Yoav Kleinberger has posted comments on this change.

Change subject: tests: fix wrong use of assertions
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/28124/2/tests/testrunner.py
File tests/testrunner.py:

Line 36: 
Line 37: 
Line 38: class TestRunnerError(Exception):
Line 39:     """
Line 40:     This is an error in the test itself (e.g. could not cleanup some temproray
> typo: 'temproray'
Done
Line 41:     file).  It is not an error in the tested code.
Line 42:     """
Line 43: 
Line 44: 


Line 396:     process = subprocess.Popen(args, stderr=subprocess.PIPE,
Line 397:                                stdout=subprocess.PIPE)
Line 398:     output, error = process.communicate()
Line 399:     if process.returncode != 0:
Line 400:         raise TestRunnerError("subprocerss failed: returncode=%s: stderr=%r" %
> typo: 'procerss'
Done
Line 401:                               (process.returncode, error))
Line 402:     return output
Line 403: 
Line 404: 


-- 
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list