Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

dkuznets at redhat.com dkuznets at redhat.com
Tue May 27 07:35:57 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: vdsm-tool: Change upgrade mechanism
......................................................................


Patch Set 8:

Assaf, the ordering is truly a bit problematic, because logging facilities only added in a latter patch, http://gerrit.ovirt.org/#/c/27481 but opposite order is not perfect either because the subsequent patch breaks the present-day upgrade mechanism, that assumes it's parameters begin at sys.argv[1:].

As for the logs produced, the following is the actual log (after removing upgrade seals):

 MainThread::INFO::2014-05-27 10:29:38,293::netconfpersistence::158::root::(_clearDisk) Clearing /var/run/vdsm/netconf/nets/ and /var/run/vdsm/netconf/bonds/
 MainThread::INFO::2014-05-27 10:29:38,294::netconfpersistence::68::root::(setNetwork) Adding network ovirtmgmt({'nic': 'eth0vnet0', 'mtu': 1500, 'bootproto': 'dhcp', 'stp': False, 'bridged': True, 'defaultRoute': True})
 MainThread::INFO::2014-05-27 10:29:38,294::netconfpersistence::158::root::(_clearDisk) Clearing /var/run/vdsm/netconf/nets/ and /var/run/vdsm/netconf/bonds/
 MainThread::INFO::2014-05-27 10:29:38,294::netconfpersistence::182::root::(save) Saved new config RunningConfig({'ovirtmgmt': {'nic': 'eth0vnet0', 'mtu': 1500, 'bootproto': 'dhcp', 'stp': False, 'bridged': True, 'defaultRoute': True}}, {}) to /var/run/vdsm/netconf/nets/ and /var/run/vdsm/netconf/bonds/

-- 
To view, visit http://gerrit.ovirt.org/27193
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1d28570dedfeff9fe60624b1db72d8cadf136a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list