Change in vdsm[master]: vm: added missing diskReplicate slot in Drive class

derez at redhat.com derez at redhat.com
Mon May 26 20:58:40 UTC 2014


Daniel Erez has posted comments on this change.

Change subject: vm: added missing diskReplicate slot in Drive class
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28131/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1026:                  'poolID', 'imageID', 'UUID', 'volumeID', 'format',
Line 1027:                  'propagateErrors', 'address', 'apparentsize', 'volumeInfo',
Line 1028:                  'index', 'name', 'optional', 'shared', 'truesize',
Line 1029:                  'volumeChain', 'baseVolumeID', 'serial', 'reqsize', 'cache',
Line 1030:                  '_blockDev', 'extSharedState', 'drv', 'sgio', 'GUID', 'diskReplicate')
> This is not enough to prevent AttributeError, it must be initialized to exi
Yes, it's the only thing that prevents the regular LSM flow from working - being initialized in '_setDiskReplica' method.
Line 1031:     VOLWM_CHUNK_MB = config.getint('irs', 'volume_utilization_chunk_mb')
Line 1032:     VOLWM_FREE_PCT = 100 - config.getint('irs', 'volume_utilization_percent')
Line 1033:     VOLWM_CHUNK_REPLICATE_MULT = 2  # Chunk multiplier during replication
Line 1034: 


-- 
To view, visit http://gerrit.ovirt.org/28131
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd1e8605786c41920f5c5f171e42fb9a12474dc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list