Change in vdsm[master]: volume: unify cow format check on creation
nsoffer at redhat.com
nsoffer at redhat.com
Mon May 26 20:46:40 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: volume: unify cow format check on creation
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/28126/1/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:
Line 128
Line 129
Line 130
Line 131
Line 132
Can you explain in the commit message why is this check wrong?
http://gerrit.ovirt.org/#/c/28126/1/vdsm/storage/fileVolume.py
File vdsm/storage/fileVolume.py:
Line 101
Line 102
Line 103
Line 104
Line 105
Can you explain in the commit message why is this check wrong?
http://gerrit.ovirt.org/#/c/28126/1/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 370: raise se.IncorrectType(type2name(preallocate))
Line 371:
Line 372: # Volumes with a parent must be cow
Line 373: if srcVolUUID != volume.BLANK_UUID and volFormat != volume.COW_FORMAT:
Line 374: raise se.IncorrectFormat(srcVolUUID)
Can you explain in the commit message why is this check right?
Line 375:
Line 376: @classmethod
Line 377: def create(cls, repoPath, sdUUID, imgUUID, size, volFormat, preallocate,
Line 378: diskType, volUUID, desc, srcImgUUID, srcVolUUID):
--
To view, visit http://gerrit.ovirt.org/28126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78401df47278cdae34d824379acd0f2d088fa7b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list