Change in vdsm[master]: json-rpc: Protocol detection

nsoffer at redhat.com nsoffer at redhat.com
Mon May 26 10:44:10 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: json-rpc: Protocol detection
......................................................................


Patch Set 20:

(1 comment)

http://gerrit.ovirt.org/#/c/26300/20/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:

Line 144:             _, client_socket = self.pending_connections[fd]
Line 145:             data = client_socket.recv(4096, socket.MSG_PEEK)
Line 146:         except socket.error as e:
Line 147:             if e.errno not in (errno.EAGAIN, errno.EINPROGRESS):
Line 148:                 self.log.warn("Not able to read data")
> Please take a look at logging module. You can see that:
But this is not documented - probably this was done for backward compatibility. To avoid confusion, we should use only the documented form. Since this module is new, there is only one correct form for this module.
Line 149:                 client_socket.close()
Line 150:             return
Line 151: 
Line 152:         handler = self.detect_protocol(data)


-- 
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list