Change in vdsm[master]: mount: Replace expensive calls to isMounted with os.path.ism...

nsoffer at redhat.com nsoffer at redhat.com
Sun May 25 21:11:10 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: mount: Replace expensive calls to isMounted with os.path.ismount
......................................................................


Patch Set 1:

I don't like this way, because touching the remote storage for checking the mount may block, while checking the local mount info is always safe.

-- 
To view, visit http://gerrit.ovirt.org/28091
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I082ea21ea3760fee1949c62da3b0ccfd82f9ce93
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list