Change in vdsm[master]: profile: Support yappi builtins option

nsoffer at redhat.com nsoffer at redhat.com
Sun May 25 19:48:18 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: profile: Support yappi builtins option
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.ovirt.org/#/c/27787/4/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 35:         ('profile_format', 'pstat',
Line 36:             'Profile file format (pstat, callgrind, ystat)'),
Line 37: 
Line 38:         ('profile_builtins', 'false',
Line 39:             'Profile builtin functions used by standart Python modules. '
> typo: standard
Thanks, will fix
Line 40:             'false by default.'),
Line 41: 
Line 42:         ('host_mem_reserve', '256',
Line 43:             'Reserves memory for the host to prevent VMs from using all the '


http://gerrit.ovirt.org/#/c/27787/4/tests/profileTests.py
File tests/profileTests.py:

Line 213: def find_module(ystats, name):
Line 214:     for func in ystats:
Line 215:         if func.module == name:
Line 216:             return True
Line 217:     return False
> Could this helper be replaced by
Nice, will update.


-- 
To view, visit http://gerrit.ovirt.org/27787
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list