Change in vdsm[master]: Final separation of IOProcess and RFH
smizrahi at redhat.com
smizrahi at redhat.com
Sun May 25 14:40:27 UTC 2014
Saggi Mizrahi has posted comments on this change.
Change subject: Final separation of IOProcess and RFH
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28088/1/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:
Line 245: def __init__(self, modname, ioproc):
Line 246: self._modName = modname
Line 247: self._ioproc = ioproc
Line 248: self.glob = _IOProcessGlob(ioproc)
Line 249: self.fileUtils.cleanupdir = \
Does not look like this can even run?
self.fileUtils was never defined.
I'd assume there will be
self.fileUtils = types.ModuleWrapper("fileUtils")
before
self.fileUtils.cleanupdir = ...
Line 250: _IOProcessFileUtils(ioproc).cleanupdir
Line 251: self.fileUtils.createdir = \
Line 252: _IOProcessFileUtils(ioproc).createdir
Line 253: self.fileUtils.validateAccess = \
--
To view, visit http://gerrit.ovirt.org/28088
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief85d2dca2d22058c4ed2504e49dc3dd62547532
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list