Change in vdsm[master]: network: publish and honor blockingdhcp setting
danken at redhat.com
danken at redhat.com
Fri May 23 11:18:00 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: network: publish and honor blockingdhcp setting
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28048/1/vdsm/network/api.py
File vdsm/network/api.py:
Line 300: if configurator is None:
Line 301: configurator = ConfiguratorClass()
Line 302:
Line 303: bootproto = options.pop('bootproto', None)
Line 304: blockingdhcp = options.pop('blockingdhcp', None)
Why should we have a tristate here (True/False/None)? Booleans with a default are nicer.
Line 305:
Line 306: netEnt = objectivizeNetwork(
Line 307: bridge=network if bridged else None, vlan=vlan, bonding=bonding,
Line 308: bondingOptions=bondingOptions, nics=nics, mtu=mtu, ipaddr=ipaddr,
http://gerrit.ovirt.org/#/c/28048/1/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 58: # 'dhcp' or 'static')
Line 59: #
Line 60: # @blockingdhcp: #optional whether ifaces that have 'dhcp' as bootproto
Line 61: # should wait to get an address before returning creation
Line 62: # success
Please state the awkward default (False).
(
I hate this option, I hate its default, and I hate it that we need to carry it along...)
Line 63: #
Line 64: # @bondingOptions: #optional A string of space-separated <option>=<value> pairs
Line 65: #
Line 66: # @qosInbound: #optional BandwidthParams for incoming traffic.
--
To view, visit http://gerrit.ovirt.org/28048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list