Change in vdsm[master]: utils: Add execCmd sync mode failing stress tests

danken at redhat.com danken at redhat.com
Thu May 22 17:18:26 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: utils: Add execCmd sync mode failing stress tests
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/27784/3/tests/utilsTests.py
File tests/utilsTests.py:

Line 530:             worker.join()
Line 531:         for worker in self.workers:
Line 532:             if worker.exc_info:
Line 533:                 type, value, tb = worker.exc_info
Line 534:                 raise type, value, tb
It's only a test, and only a short function, but would you avoid hiding the "type" builtin?
Line 535: 
Line 536:     def read_stderr(self):
Line 537:         args = ['if=/dev/zero',
Line 538:                 'of=/dev/null',


-- 
To view, visit http://gerrit.ovirt.org/27784
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57ebd5faf028ccfc928a8b2e7ae47008f0970c23
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list