Change in vdsm[master]: json-rpc: Protocol detection

ybronhei at redhat.com ybronhei at redhat.com
Thu May 22 09:48:41 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: json-rpc: Protocol detection
......................................................................


Patch Set 16:

(2 comments)

http://gerrit.ovirt.org/#/c/26300/16/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:

Line 84:     def load_json(self, bridge):
Line 85:         from BindingJsonRpc import BindingJsonRpc
Line 86: 
Line 87:         self._jsonBinding = BindingJsonRpc(bridge)
Line 88:         self._jsonBinding.start()
> I can't crash. By user will in config there can be one or the other protoco
but why do you start the Detecotor when one disabled? it doesn't really matter. leave it as is. i just think its waist of unused thread if the protocol is disabled
Line 89: 
Line 90:     def load_xml(self, cif):
Line 91:         from BindingXMLRPC import BindingXMLRPC
Line 92: 


Line 113:         os.write(self._write_fd, '1')
Line 114: 
Line 115:     def _cleanup(self):
Line 116:         os.read(self._read_fd, 1)
Line 117: 
> I already modified that it patch set 17. Nir asked for that. This is a way 
if already 2 guys asked for explanation i think it worth comment here. sorry to miss your response to nir.
Line 118:     def _accept_conn(self):
Line 119:         client_socket, socket_address = self.socket.accept()
Line 120:         client_socket.settimeout(self._timeout)
Line 121:         return (client_socket, socket_address)


-- 
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list