Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

dfediuck at redhat.com dfediuck at redhat.com
Thu May 22 06:47:11 UTC 2014


Doron Fediuck has posted comments on this change.

Change subject: Adding utility methods and conf for CPU limit MOM integration
......................................................................


Patch Set 20:

(3 comments)

http://gerrit.ovirt.org/#/c/27258/20/vdsm/API.py
File vdsm/API.py:

Line 709:     def setCpuTuneQuota(self, quota):
Line 710:         v = self._cif.vmContainer.get(self._UUID)
Line 711:         if not v:
Line 712:             return errCode['noVM']
Line 713:         return v.setCpuTuneQuota(quota)
> Can you add a short explanation/link to what is the schema file and how it 
Kobi, take a look in vdsm_api/vdsmapi-schema.json
Line 714: 
Line 715:     def setCpuTunePeriod(self, period):
Line 716:         v = self._cif.vmContainer.get(self._UUID)
Line 717:         if not v:


http://gerrit.ovirt.org/#/c/27258/20/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4404:                 else:
Line 4405:                     ret['vcpu_user_limit'] = 100
Line 4406: 
Line 4407:         except (AttributeError, libvirt.libvirtError):
Line 4408:             # Metadata is not set, nothing to do, set the defaults
> it's a debug level, so in production the user will not see it,
I believe Dan refers to the fact that you report 100 instead of none.
Line 4409:             self.log.debug('Domain Metadata is not set')
Line 4410:             ret['vcpu_user_limit'] = 100
Line 4411:         return ret
Line 4412: 


Line 4503:             if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 4504:                 return self.reportError(key='noVM', entity='vcpu period')
Line 4505:             return self.reportError(msg=e.message, entity='vcpu period')
Line 4506: 
Line 4507:     def reportError(self, key='Err', msg=None, entity=None):
> how do I mark it as private?
Use _reportError
Line 4508:         self.log.error("Set new "+entity+" failed", exc_info=True)
Line 4509:         if msg is None:
Line 4510:             error = errCode[key]
Line 4511:         else:


-- 
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list