Change in vdsm[master]: taskManager: improve task queuing error logging

danken at redhat.com danken at redhat.com
Wed May 21 15:59:06 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: taskManager: improve task queuing error logging
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/27979/3/vdsm/storage/taskManager.py
File vdsm/storage/taskManager.py:

Line 54:                 del self._tasks[task.id]
Line 55:                 raise se.AddTaskError()
Line 56:             self.log.debug("task queued: %s", task.id)
Line 57:         except Exception:
Line 58:             self.log.exception('could not queue task %s', task.id)
> In the end I decided that using "exception" is the best. We get the specifi
your call, though I dislike double tracebacks.
Line 59:             raise
Line 60: 
Line 61:         return task.id
Line 62: 


-- 
To view, visit http://gerrit.ovirt.org/27979
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3cb39091c59e92c8852e863ebb2cdc61594e5aa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list