Change in vdsm[master]: virt: migration: merge monitor and downtime thread

asegurap at redhat.com asegurap at redhat.com
Wed May 21 11:14:54 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: virt: migration: merge monitor and downtime thread
......................................................................


Patch Set 16: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/25977/16/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 443:             self._vm.log.info('Migration Progress: %s seconds elapsed, %s%% of'
Line 444:                               ' data processed' %
Line 445:                               (timeElapsed / 1000, self.progress))
Line 446: 
Line 447:     def update_downtime(self, i):
This is just a convenience method. It is not consistent that monitor_migration would have calculateProgress as an internal method (and camel cased) and that monitor_downtime would have update_downtime as an external method (and var_foo cased). What about to have it be calculate_downtime as an internal method?
Line 448:         return self._downtime * (i + 1) / self._DOWNTIME_STEPS
Line 449: 
Line 450:     def monitor_downtime(self, step):
Line 451:         if (self._downtimeStep < self._DOWNTIME_STEPS and


-- 
To view, visit http://gerrit.ovirt.org/25977
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list