Change in vdsm[master]: json-rpc: Protocol detection

ybronhei at redhat.com ybronhei at redhat.com
Wed May 21 06:49:32 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: json-rpc: Protocol detection
......................................................................


Patch Set 16:

(2 comments)

http://gerrit.ovirt.org/#/c/26300/16/vdsm.spec.in
File vdsm.spec.in:

Line 1398: %dir %{_datadir}/%{vdsm_name}
Line 1399: %{_datadir}/%{vdsm_name}/BindingXMLRPC.py*
Line 1400: 
Line 1401: %files jsonrpc
Line 1402: %doc vdsm_api/vdsm-api.html
why do we still have vdsm_api directory? remove it
Line 1403: %{_datadir}/%{vdsm_name}/BindingJsonRpc.py*
Line 1404: %{_datadir}/%{vdsm_name}/Bridge.py*
Line 1405: %{_datadir}/%{vdsm_name}/vdsmapi-schema.json
Line 1406: %{python_sitelib}/vdsmapi.py*


http://gerrit.ovirt.org/#/c/26300/16/vdsm_api/BindingJsonRpc.py
File vdsm_api/BindingJsonRpc.py:

Line 1: # VDSM JsonRPC Server
maybe worth to change also the location of those files if we remove vdsm-api rpm. most of this code relates to vdsm core and can be under vdsm/ dir or under vdsm/rpc | lib/vdsm/rpc
Line 2: # Copyright (C) 2012 Adam Litke, IBM Corporation
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License version 2 as


-- 
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list