Change in vdsm[master]: netinfo: Read default bonding options

danken at redhat.com danken at redhat.com
Tue May 20 17:21:35 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Read default bonding options
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/27680/9/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 604:     return opts
Line 605: 
Line 606: 
Line 607: @memoized
Line 608: def _getDefaultBondingOptions(mode=None):
this method should be declared public, if we ever intend to call it out of this module.
Line 609:     """
Line 610:     Return default options for the given mode. If it is None, return options
Line 611:     for the default mode (usually '0').
Line 612:     """


Line 617: 
Line 618:     return defaults[mode]
Line 619: 
Line 620: 
Line 621: def _getBondingOptions(bond):
I think that this method should be public, too.
Line 622:     """
Line 623:     Return non-empty options differing from defaults, excluding not actual or
Line 624:     not applicable options, e.g. 'ad_num_ports' or 'slaves'.
Line 625:     """


-- 
To view, visit http://gerrit.ovirt.org/27680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list