Change in vdsm[master]: vm: simplify the releaseVm flow

fromani at redhat.com fromani at redhat.com
Tue May 20 15:50:59 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: simplify the releaseVm flow
......................................................................


Patch Set 2: Verified+1

Verification:
- booted a VM
- on the hypervisor host, sent SIGSTOP to QEMU:
# kill -STOP #QEMU_PID
- powered off the VM from engine

relevant log lines demonstrating the correct behaviour

Thread-2813::DEBUG::2014-05-20 17:44:26,054::BindingXMLRPC::1056::vds::(wrapper) client [192.168.1.64]::call vmDestroy with ('ca720054-a208-44af-8fdd-edc2ec5c80a9',) {} flowID [3a516857]
Thread-2813::INFO::2014-05-20 17:44:26,054::API::334::vds::(destroy) vmContainerLock acquired by vm ca720054-a208-44af-8fdd-edc2ec5c80a9
Thread-2813::DEBUG::2014-05-20 17:44:26,054::vm::4481::vm.Vm::(destroy) vmId=`ca720054-a208-44af-8fdd-edc2ec5c80a9`::destroy Called

Thread-2813::DEBUG::2014-05-20 17:44:41,102::libvirtconnection::125::root::(wrapper) Unknown libvirterror: ecode: 9 edom: 10 level: 2 message: operation failed: failed to kill qemu process with SIGTERM
Thread-2813::WARNING::2014-05-20 17:44:41,102::vm::4465::vm.Vm::(_destroyVm) vmId=`ca720054-a208-44af-8fdd-edc2ec5c80a9`::Failed to destroy VM 'ca720054-a208-44af-8fdd-edc2ec5c80a9' gracefully

libvirtEventLoop::DEBUG::2014-05-20 17:44:51,641::vm::5005::vm.Vm::(_onLibvirtLifecycleEvent) vmId=`ca720054-a208-44af-8fdd-edc2ec5c80a9`::event Stopped detail 1 opaque None
Thread-2813::DEBUG::2014-05-20 17:44:51,641::task::595::TaskManager.Task::(_updateState) Task=`9c39b85a-8504-4bcf-a81e-6de46fb2f5b0`::moving from state init -> state preparing
libvirtEventLoop::INFO::2014-05-20 17:44:51,642::vm::2108::vm.Vm::(_onQemuDeath) vmId=`ca720054-a208-44af-8fdd-edc2ec5c80a9`::underlying process disconnected

Thread-2813::DEBUG::2014-05-20 17:44:51,937::vm::4475::vm.Vm::(deleteVm) vmId=`ca720054-a208-44af-8fdd-edc2ec5c80a9`::Total desktops after destroy of ca720054-a208-44af-8fdd-edc2ec5c80a9 is 0
libvirtEventLoop::DEBUG::2014-05-20 17:44:51,938::vm::2489::vm.Vm::(setDownStatus) vmId=`ca720054-a208-44af-8fdd-edc2ec5c80a9`::Changed state to Down: Admin shut down from the engine (code=6)
Thread-2813::DEBUG::2014-05-20 17:44:51,940::BindingXMLRPC::1063::vds::(wrapper) return vmDestroy with {'status': {'message': 'Machine destroyed', 'code': 0}}

happy path not affected but trivially verified as well

-- 
To view, visit http://gerrit.ovirt.org/27175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia25794217e63dd4c755d9c141a2e941e4baa6fd3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list