Change in vdsm[master]: utils: Add execCmd sync mode failing stress tests

danken at redhat.com danken at redhat.com
Tue May 20 14:55:58 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: utils: Add execCmd sync mode failing stress tests
......................................................................


Patch Set 2:

(2 comments)

Saggi, we should re-implement standard functions only when have a specific bug in them, and we cannot solve that bug upstream. Can you recall the specific communicate() bug that made us do that here? I failed to recall (and failed to document it in the past).

Nir: minor comments of a partial review.

http://gerrit.ovirt.org/#/c/27784/2/tests/utilsTests.py
File tests/utilsTests.py:

Line 510:     @stresstest
Line 511:     def test_read_stdout_stderr(self):
Line 512:         self.check(self.read_stdout_stderr)
Line 513: 
Line 514:     @stresstest
can you mark it with @brokentest('AsyncProc is broken') until this is to be solved?
Line 515:     def test_write_stdin_read_stderr(self):
Line 516:         self.data = 'x' * self.BLOCK_SIZE * self.BLOCK_COUNT
Line 517:         self.check(self.write_stdin_read_stderr)
Line 518: 


Line 548:                 'count=%d' % self.BLOCK_COUNT]
Line 549:         out = self.run_dd(args)
Line 550:         size = self.BLOCK_SIZE * self.BLOCK_COUNT
Line 551:         if len(out) < size:
Line 552:             raise Exception("Partial read: %d/%d" % (len(out), size))
You should

  raise self.failureException()

as this case should count as a failed test, not as an error in the test framework.
Line 553: 
Line 554:     def write_stdin_read_stderr(self):
Line 555:         args = ['of=/dev/null',
Line 556:                 'bs=%d' % self.BLOCK_SIZE,


-- 
To view, visit http://gerrit.ovirt.org/27784
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57ebd5faf028ccfc928a8b2e7ae47008f0970c23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list