Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

dkuznets at redhat.com dkuznets at redhat.com
Tue May 20 10:07:15 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: pep8: Fix indentation in supervdsmServer
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27899/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 265:     @logDecorator
Line 266:     def appropriateDevice(self, guid, thiefId):
Line 267:         ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId)
Line 268:         rule = 'SYMLINK=="mapper/%s", OWNER="%s", GROUP="%s"\n' % \
Line 269:             (guid, DISKIMAGE_USER, DISKIMAGE_GROUP)
> For Python files '(' is preferred to escaping '\'. Thus, this could just be
Done
Line 270:         with open(ruleFile, "w") as rf:
Line 271:             self.log.debug("Creating rule %s: %r", ruleFile, rule)
Line 272:             rf.write(rule)
Line 273: 


-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list