Change in vdsm[master]: netinfo: Read default bonding options

danken at redhat.com danken at redhat.com
Tue May 20 10:04:46 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Read default bonding options
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/27680/5//COMMIT_MSG
Commit Message:

Line 12: Some sysfs entries are ignored as they are not actually
Line 13: "options", e.g. 'active_slave', 'ad_partner_mac'.
Line 14: 
Line 15: Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915
Line 16: Bug-Url: https://bugzilla.redhat.com/987813
this patch solves nothing, hence it is only

 Related-To:


http://gerrit.ovirt.org/#/c/27680/5/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 183:                 el for el in optFile.read().rstrip().split(' ') if el]
Line 184:     return opts
Line 185: 
Line 186: 
Line 187: def realBondOpts(bond, keys=None):
please keep this function module-private
Line 188:     """
Line 189:     Returns a dictionary in the same format as bondOpts(). Values that are not
Line 190:     actually options are excluded, e.g. 'ad_num_ports' or 'slaves'.
Line 191:     """


Line 188:     """
Line 189:     Returns a dictionary in the same format as bondOpts(). Values that are not
Line 190:     actually options are excluded, e.g. 'ad_num_ports' or 'slaves'.
Line 191:     """
Line 192:     EXCLUDED = frozenset(('slaves',  'active_slave', 'mii_status', 'queue_id',
Please define this out of the function.
Line 193:                           'ad_aggregator', 'ad_num_ports', 'ad_actor_key',
Line 194:                           'ad_partner_key', 'ad_partner_mac'))
Line 195: 
Line 196:     return dict(((opt, val) for (opt, val) in bondOpts(bond, keys).iteritems()


-- 
To view, visit http://gerrit.ovirt.org/27680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list