Change in vdsm[master]: vdsm-tool: add the cmd get-ca-issuer

ybronhei at redhat.com ybronhei at redhat.com
Mon May 19 15:50:45 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-tool: add the cmd get-ca-issuer
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/27651/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: If oVirt Node is registered via oVirt Engine currently
Line 10: we don't show to users which engine the node is registered.
Line 11: This patch extracts the issuer field from cacert.pem to use
Line 12: the CN (commonname) data in ovirt-node-plugin-vdsm.
why in the tool?? it really sounds like something that vdsm should expose. I would put it in vdsCaps or even new api

other than that, alonbl planned to as "registration tool" exactly for such issues like knowing the process better then the current scripts. as part of this tool, which relevant only for nodes, we can expose such api.

I really don't think vdsm-tool is right for that propose. please convince me that im wrong
Line 13: 
Line 14: Change-Id: I70a19f54169498c53cabba0ac75e7a5611762ece
Line 15: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1039267


-- 
To view, visit http://gerrit.ovirt.org/27651
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70a19f54169498c53cabba0ac75e7a5611762ece
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list