Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class

danken at redhat.com danken at redhat.com
Mon May 19 12:50:04 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: virt: graphdev: add the GraphicsDevice class
......................................................................


Patch Set 28: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/26895/28/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4326:     def hasSpice(self):
Line 4327:         return (self.conf.get('display') == 'qxl' or
Line 4328:                 any(dev['device'] == 'spice'
Line 4329:                     for dev in self.conf.get('devices', [])
Line 4330:                     if dev['type'] == GRAPHICS_DEVICES))
> Wouldn't it be more readable:
I'm not sure. And much like you, not going to block on that.
Line 4331: 
Line 4332:     def _getPid(self):
Line 4333:         pid = '0'
Line 4334:         try:


-- 
To view, visit http://gerrit.ovirt.org/26895
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list