Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge

asegurap at redhat.com asegurap at redhat.com
Thu May 15 17:20:46 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: hooks: macbind - Attach vm nics to specified bridge
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

Only one very minor thing, otherwise it is fine.

http://gerrit.ovirt.org/#/c/17895/9/vdsm_hooks/macbind/before_vm_start.py
File vdsm_hooks/macbind/before_vm_start.py:

Line 1: #!/usr/bin/python
this should be
#!/usr/bin/env python2

and have the copyright notice afterwards.
Line 2: 
Line 3: import ast
Line 4: import os
Line 5: import sys


-- 
To view, visit http://gerrit.ovirt.org/17895
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list