Change in vdsm[master]: volume: use qemuimg and remove custom createVolume

danken at redhat.com danken at redhat.com
Thu May 15 16:50:00 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: volume: use qemuimg and remove custom createVolume
......................................................................


volume: use qemuimg and remove custom createVolume

This patch substitutes a custom createVolume function with the more
standard implementation in qemuimg module.
As a side-effect the 'preallocate' flag for the clone method became
useless and it has been removed.

Change-Id: I960276ec6bd654be4f427425c95603189c0d6a99
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/26871
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/volume.py
3 files changed, 15 insertions(+), 76 deletions(-)

Approvals:
  Federico Simoncelli: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I960276ec6bd654be4f427425c95603189c0d6a99
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list