Change in vdsm[master]: vm: Automatically add a serial port for a console device
fromani at redhat.com
fromani at redhat.com
Thu May 15 16:02:05 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: vm: Automatically add a serial port for a console device
......................................................................
Patch Set 6:
(1 comment)
I agree with Toni here. Spice GraphicsDevices may be another case of composite devices (for spice vmc channels), or anyway a case worth considering.
http://gerrit.ovirt.org/#/c/25979/6/tests/vmTests.py
File tests/vmTests.py:
Line 300: self.assertXML(console.getXML(), consoleXML)
Line 301: domxml = vm._DomXML(self.conf, self.log,
Line 302: caps.Architecture.X86_64)
Line 303: domxml.appendConsoleSerial()
Line 304: assert(len(domxml._devices.getElementsByTagName('serial')) == 0)
I'd use self.assertFalse for better reporting
Line 305: domxml._devices.appendChild(console.getXML())
Line 306: domxml.appendConsoleSerial()
Line 307: self.assertXML(domxml._devices, serialXML, 'serial')
Line 308:
--
To view, visit http://gerrit.ovirt.org/25979
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7b02a7bcaad63017c35c811a194fa42e2b694f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list