Change in vdsm[master]: network: Reset a bond's options to defaults before using it

osvoboda at redhat.com osvoboda at redhat.com
Thu May 15 10:29:55 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: network: Reset a bond's options to defaults before using it
......................................................................


Patch Set 12:

(1 comment)

Why the test failed.

http://gerrit.ovirt.org/#/c/26374/12/vdsm/network/models.py
File vdsm/network/models.py:

Line 239
Line 240
Line 241
Line 242
Line 243
What is the reason for replacing purposedly empty options with the the current state? This way, e.g. testSetupNetworksResizeBond fails with miimon=9 already set for the bond (left over from a previous run of all the tests).

If bonds are reused during VDSM’s lifetime (and their options can be changed at will) this is really an issue.


-- 
To view, visit http://gerrit.ovirt.org/26374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list