Change in vdsm[master]: sp: Remove uneeded error handler
nsoffer at redhat.com
nsoffer at redhat.com
Thu May 15 06:44:56 UTC 2014
Nir Soffer has uploaded a new change for review.
Change subject: sp: Remove uneeded error handler
......................................................................
sp: Remove uneeded error handler
domainMointor module does not raise StorageException and handling it
does not help anyone.
Change-Id: Ic540ddb6644e445e2606e752371f1bf635a4227f
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/storage/sp.py
1 file changed, 6 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/27713/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 1e9bcaa..cada2ab 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1394,24 +1394,15 @@
for sdUUID in monitoredDomains:
if sdUUID not in activeDomains:
- try:
- self.domainMonitor.stopMonitoring(sdUUID)
- self.log.debug("Storage Pool `%s` stopped monitoring "
- "domain `%s`", self.spUUID, sdUUID)
- except se.StorageException:
- self.log.error("Unexpected error while trying to stop "
- "monitoring domain `%s`", sdUUID,
- exc_info=True)
+ self.domainMonitor.stopMonitoring(sdUUID)
+ self.log.debug("Storage Pool `%s` stopped monitoring "
+ "domain `%s`", self.spUUID, sdUUID)
for sdUUID in activeDomains:
if sdUUID not in monitoredDomains:
- try:
- self.domainMonitor.startMonitoring(sdUUID, self.id)
- self.log.debug("Storage Pool `%s` started monitoring "
- "domain `%s`", self.spUUID, sdUUID)
- except se.StorageException:
- self.log.error("Unexpected error while trying to monitor "
- "domain `%s`", sdUUID, exc_info=True)
+ self.domainMonitor.startMonitoring(sdUUID, self.id)
+ self.log.debug("Storage Pool `%s` started monitoring "
+ "domain `%s`", self.spUUID, sdUUID)
@unsecured
def getDomains(self, activeOnly=False):
--
To view, visit http://gerrit.ovirt.org/27713
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic540ddb6644e445e2606e752371f1bf635a4227f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
More information about the vdsm-patches
mailing list