Change in vdsm[master]: ipwrapper, configurators: Wait for bonds to go up

asegurap at redhat.com asegurap at redhat.com
Thu May 15 06:37:45 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: ipwrapper, configurators: Wait for bonds to go up
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

Only as a minor comment to remove the todo note.

http://gerrit.ovirt.org/#/c/26930/10/lib/vdsm/ipwrapper.py
File lib/vdsm/ipwrapper.py:

Line 692: 
Line 693: @contextmanager
Line 694: def waitForLinkUp(iface, timeout=3):
Line 695:     """IfUpTimeout is raised if a timeout of 3 seconds expires.
Line 696:     TODO: A timeout could be moved to Monitor."""
I don't think it is necessary to have this explicit TODO here.
Line 697:     monitor = Monitor()
Line 698:     monitor.start()
Line 699:     thread = threading.Thread(target=_waitingThread, args=(iface, monitor))
Line 700:     thread.daemon = False


-- 
To view, visit http://gerrit.ovirt.org/26930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf52b33e8efd7eeecd665dacf9b156cd197c066
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list