Change in vdsm[master]: caps: drop a non-surprising error report

danken at redhat.com danken at redhat.com
Wed May 14 20:14:27 UTC 2014


Dan Kenigsberg has uploaded a new change for review.

Change subject: caps: drop a non-surprising error report
......................................................................

caps: drop a non-surprising error report

Commit 60dd97a84 changed getVdsCaps to report whether we support live
snapshots. Usually, not having the relevant architecture in libvirt's
capapbilities is indeed a bug. However, this is not the case when we are
faking kvm support.

Change-Id: I5e8da158314420898935691e05db4591aa9176ec
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/caps.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/27704/1

diff --git a/vdsm/caps.py b/vdsm/caps.py
index 284d3aa..46094f3 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -207,7 +207,9 @@
         if archTag.getAttribute('name') == arch:
             return _findLiveSnapshotSupport(guestTag)
 
-    logging.error("missing guest arch tag in the capabilities XML")
+    if not config.getboolean('vars', 'fake_kvm_support'):
+        logging.error("missing guest arch tag in the capabilities XML")
+
     return None
 
 


-- 
To view, visit http://gerrit.ovirt.org/27704
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e8da158314420898935691e05db4591aa9176ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list