Change in vdsm[master]: fileVolume: create file volume with correct mode
danken at redhat.com
danken at redhat.com
Wed May 14 17:17:17 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: fileVolume: create file volume with correct mode
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/27593/2/vdsm/storage/fileVolume.py
File vdsm/storage/fileVolume.py:
Line 155: imgUUID, volUUID, srcImgUUID, srcVolUUID)
Line 156: volParent.clone(imgPath, volUUID, volFormat, preallocate)
Line 157:
Line 158: # Forcing the volume permissions in case one of the tools we use
Line 159: # (dd, qemu-img, etc.) will mistakenly change the file permissiosn.
hopefully the two remaining usages of file_setrw would follow suit...
Line 160: dom.oop.os.chmod(volPath, VOLUME_PERMISSIONS)
Line 161:
Line 162: return (volPath,)
Line 163:
--
To view, visit http://gerrit.ovirt.org/27593
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38aabad8d3662d6de0a24c33a0f73976a3e98ce3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list