Change in vdsm[master]: netinfo: Read default bonding options

osvoboda at redhat.com osvoboda at redhat.com
Wed May 14 12:32:34 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: Read default bonding options
......................................................................


Patch Set 1:

(1 comment)

About the (original) choice of a numerical value from sysfs. E.g. the mode is presented as 'balance-rr 0' and currently, we return the number as the bonding option value.

http://gerrit.ovirt.org/#/c/27680/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 623: def _bondOptsForIfcfg(opts):
Line 624:     '''
Line 625:     Options having symbolic values, e.g. 'mode', are presented by sysfs in
Line 626:     the order symbolic name, numeric value, e.g. 'balance-rr 0'.
Line 627:     From a list given by bondOpts(), the numeric value is chosen.
In functional tests in the last patch, to be able to compare requested values to resulting ones we have to stick either to numeric values or symbolic values. For readability we might want to switch to symbolic values.
Line 628:     '''
Line 629:     return ' '.join((opt + '=' + val[-1] for (opt, val)
Line 630:                      in sorted(opts.iteritems())))
Line 631: 


-- 
To view, visit http://gerrit.ovirt.org/27680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list