Change in vdsm[master]: domainMonitor: Stop domain monitors concurrently

asegurap at redhat.com asegurap at redhat.com
Wed May 14 10:20:36 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: domainMonitor: Stop domain monitors concurrently
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/27573/1/vdsm/storage/domainMonitor.py
File vdsm/storage/domainMonitor.py:

Line 246: 
Line 247:             self.nextStatus.readDelay = self.domain.getReadDelay()
Line 248: 
Line 249:             # I could have been stopped while waiting for storage
Line 250:             if not self._running():
It would be better if we had this break away points be methods that if the monitor is not running they raise and stop the monitor.
Line 251:                 return
Line 252: 
Line 253:             stats = self.domain.getStats()
Line 254:             self.nextStatus.diskUtilization = (stats["disktotal"],


-- 
To view, visit http://gerrit.ovirt.org/27573
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12f137f1ed055316767e1a9384d8982720bc564
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list