Change in vdsm[master]: vdsm-tool: Change exception reporting

asegurap at redhat.com asegurap at redhat.com
Wed May 14 07:59:44 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: vdsm-tool: Change exception reporting
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

Very small nits

http://gerrit.ovirt.org/#/c/26565/6/lib/vdsm/tool/__init__.py
File lib/vdsm/tool/__init__.py:

Line 32: 
Line 33: 
Line 34: class NotRootError(UsageError):
Line 35:     def __init__(self):
Line 36:         UsageError.__init__(self, "Must run as root")
this should be, in order to keep with the inheritance possibilities:
super(NotRootError, self).__init__('Must run as root')


http://gerrit.ovirt.org/#/c/26565/6/lib/vdsm/tool/restore_nets.py
File lib/vdsm/tool/restore_nets.py:

Line 35:     sys.stdout.write(out)
Line 36:     sys.stderr.write(err)
Line 37:     if rc != 0:
Line 38:         raise EnvironmentError(
Line 39:             'Failed to restore the persisted networks'
Please, move ')' to the line number 39. No need to add more lines.


-- 
To view, visit http://gerrit.ovirt.org/26565
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I467d1e5ef7503312cde6e013aacb68dc2d46dd37
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list