Change in vdsm[master]: replace configure_libvirt.py with python code.
Alon Bar-Lev
alonbl at redhat.com
Tue May 13 17:23:52 UTC 2014
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
......................................................................
Patch Set 7:
(1 comment)
ok, I am done, looks ok, I am sure there are more cleanups that can be done, but I do think it is enough for now.
http://gerrit.ovirt.org/#/c/27298/7/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 400: def getPersistedFiles(self):
Line 401: return [
Line 402: cfile['path'] for cfile in self.FILES.values()
Line 403: if cfile['configure'].__name__ == 'prefixAndPrepend' or
Line 404: cfile['configure'].__name__ == 'addSection'
I would have added boolean property instead of this complex condition.
Line 405: ]
Line 406:
Line 407: def _sysvToUpstart(self):
Line 408: """
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list