Change in vdsm[master]: core: generify "streamDownloadImage" related methods
ykleinbe at redhat.com
ykleinbe at redhat.com
Tue May 13 12:17:04 UTC 2014
Yoav Kleinberger has posted comments on this change.
Change subject: core: generify "streamDownloadImage" related methods
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
among other things, this change introduces a bug, see my comments.
http://gerrit.ovirt.org/#/c/26761/2/vdsm/storage/image.py
File vdsm/storage/image.py:
Line 1183
Line 1184
Line 1185
Line 1186
Line 1187
getLengthFromArgs here is not good. Why use a lower layer to find out things that are totally defined in this layer?
just write methodArgs['contentLength'] right here.
Line 1182: vol = self._activateVolumeForImportExport(domain, imgUUID, volUUID)
Line 1183: try:
Line 1184: # Extend the volume (if relevant) to the image size
Line 1185: vol.extend(imageSharing.
Line 1186: getLengthFromArgs(methodArgs) / volume.BLOCK_SIZE)
don't break the line after a period - "." this is very confusing
Line 1187: imageSharing.copyToImage(vol.getVolumePath(), methodArgs)
Line 1188: finally:
--
To view, visit http://gerrit.ovirt.org/26761
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c73374681b5a5fc9fd0cb81020138fb5c8bfe69
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list