Change in vdsm[master]: spice: allow to disable the to clipboard copypaste

vfeenstr at redhat.com vfeenstr at redhat.com
Tue May 13 11:47:11 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: spice: allow to disable the to clipboard copypaste
......................................................................


Patch Set 25: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/26916/25/tests/vmTests.py
File tests/vmTests.py:

Line 87:             <channel mode="secure" name="cursor"/>
Line 88:             <channel mode="secure" name="playback"/>
Line 89:             <channel mode="secure" name="record"/>
Line 90:             <channel mode="secure" name="display"/>
Line 91:         </graphics>""",
You add two results here but only one configuration, couldn't you put it on the depending patchset?
Line 92: 
Line 93:         """
Line 94:         <graphics autoport="yes" listen="0" passwd="*****"
Line 95:                   passwdValidTo="1970-01-01T00:00:01" port="-1"


http://gerrit.ovirt.org/#/c/26916/25/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:

Line 3244: copyPasteEnable
If this is optional it needs to be prefixed with *


-- 
To view, visit http://gerrit.ovirt.org/26916
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list