Change in vdsm[master]: virt: graphdev: handle ticket for multiple devices
fromani at redhat.com
fromani at redhat.com
Tue May 13 07:35:34 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
......................................................................
Patch Set 26:
(3 comments)
http://gerrit.ovirt.org/#/c/26897/26//COMMIT_MSG
Commit Message:
Line 6:
Line 7: virt: graphdev: handle ticket for multiple devices
Line 8:
Line 9: This patch extends the ticket support for the
Line 10: multiple graphics devices scenario.
> it also adds a completely new usage to the updateDevice API, which deserves
Will extend the commit message with a concise description of the new usage.
Line 11:
Line 12: Change-Id: I62f56ea47399b0d26aafce053ea1201457564b73
http://gerrit.ovirt.org/#/c/26897/26/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4405:
Line 4406: def _reviveTicket(self, newlife):
Line 4407: """
Line 4408: Revive an existing ticket, if it has expired or about to expire.
Line 4409: Will be called if VM has a SPICE device.
> please explain why this is irrelevant to vnc devices
The migration code (migration.SourceThread._startUnderlyingMigration) actually calls this method only for spice graphics, so I added this comment in the docstring; however, after verifying in the libvirt docs I don't see why it should not work for vnc.
So I'll just remove the docstring line which is misleading.
Line 4410: """
Line 4411: graphics = self._findGraphicsDevice('spice')
Line 4412: validto = max(time.strptime(graphics.getAttribute('passwdValidTo'),
Line 4413: '%Y-%m-%dT%H:%M:%S'),
Line 4418: self._dom.updateDeviceFlags(graphics.toxml(), 0)
Line 4419:
Line 4420: def _findGraphicsDevice(self, deviceType):
Line 4421: """
Line 4422: libvirt (as in 1.2.3) supports only one graphic device per type
> but can we be a bit more future-compatible that that? Does libvirt plan to
Will check libvirt future plans.
As in libvirt 1.2.4, if I create a domain using libvirt and check the domain xml after (dumpxml), there is no alias in sight:
(relevant portion)
<graphics type='spice' port='5900' autoport='yes' listen='127.0.0.1'>
<listen type='address' address='127.0.0.1'/>
</graphics>
<graphics type='vnc' port='5901' autoport='yes' listen='127.0.0.1'>
<listen type='address' address='127.0.0.1'/>
</graphics>
Line 4423: """
Line 4424: for graphics in _domParseStr(
Line 4425: self._dom.XMLDesc(libvirt.VIR_DOMAIN_XML_SECURE)). \
Line 4426: childNodes[0].getElementsByTagName('graphics'):
--
To view, visit http://gerrit.ovirt.org/26897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62f56ea47399b0d26aafce053ea1201457564b73
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list