Change in vdsm[master]: replace configure_libvirt.py with python code.
Alon Bar-Lev
alonbl at redhat.com
Mon May 12 17:36:24 UTC 2014
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/6/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 98: 'path': os.path.join(
Line 99: SYSCONF_PATH,
Line 100: 'libvirt/libvirtd.conf'
Line 101: ),
Line 102: 'configureFunc': 'addSection',
> This only works if the functions are defined above FILES. maybe I should mo
why do you care if function is above :)
you can also write:
def xxx(*args):
self._xxx(*args)
so you have only two lines above.
Line 103: 'removeConfFunc': 'removeSection',
Line 104: 'fragments': [
Line 105: {
Line 106: 'conditions': {},
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list