Change in vdsm[master]: distribute logrotate libvirtd configuration file with vdsm.

Alon Bar-Lev alonbl at redhat.com
Mon May 12 16:41:45 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: distribute logrotate libvirtd configuration file with vdsm.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27564/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 299:             with open(os.path.join(
Line 300:                     P_VDSM,
Line 301:                     'tool',
Line 302:                     'libvirtd'), 'r') as lloger_conf:
Line 303:                             conf.prependSection(lloger_conf.read())
> what vdsm does is
but there is no need for this when we own the entire file... no?

also, why don't just provide the logrotate in the packaging? why do we need to create this at runtime?
Line 304:             conf.prependSection(self.LLOGR_CONF)
Line 305: 
Line 306:         if utils.isOvirtNode():
Line 307:             from ovirtnode import ovirtfunctions


-- 
To view, visit http://gerrit.ovirt.org/27564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98a0c4dd880727332d6ed2faeec0fe64d3835532
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list