Change in vdsm[master]: replace configure_libvirt.py with python code.

mtayer at redhat.com mtayer at redhat.com
Mon May 12 16:25:26 UTC 2014


mooli tayer has posted comments on this change.

Change subject: replace configure_libvirt.py with python code.
......................................................................


Patch Set 5: Verified+1

(1 comment)

http://gerrit.ovirt.org/#/c/27298/5/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 353:                 if not os.path.isfile(TARGET):
Line 354:                     service.service_stop('libvirtd')
Line 355:                 if not os.path.isfile(TARGET) or \
Line 356:                         not filecmp.cmp(packeged, TARGET):
Line 357:                     shutil.copyfile(packeged, TARGET)
> you need to keep the destination mode, you can either save it and restore a
Done
Line 358:                     rc, out, err = utils.execCmd((INITCTL,
Line 359:                                                   "reload-configuration"))
Line 360:                     if rc != 0:
Line 361:                         sys.stdout.write(out)


-- 
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list