Change in vdsm[master]: vm: drop the display params after device creation

danken at redhat.com danken at redhat.com
Mon May 12 16:21:29 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: drop the display params after device creation
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/27595/1//COMMIT_MSG
Commit Message:

Line 7: vm: drop the display params after device creation
Line 8: 
Line 9: Once the devices of a Vm are been created, to keep
Line 10: the display* parameters in the Vm.conf only leads
Line 11: to confusion and more corner cases to handle, so this
Could you give a sample corner case? I think that it's simpler to keep legacy reports as they are; new Engines and Vdsm would disregard them if a graphics device exists in "devices".

Wouldn't this patch confuse old Engines?
Line 12: patch deletes them from the configuration.
Line 13: 
Line 14: Change-Id: I4aa8096de1f9d798f6d42d640420efebc2e2c3b0


-- 
To view, visit http://gerrit.ovirt.org/27595
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aa8096de1f9d798f6d42d640420efebc2e2c3b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list