Change in vdsm[master]: misc: Faster version of readspeed

Federico Simoncelli fsimonce at redhat.com
Mon May 12 09:07:16 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: misc: Faster version of readspeed
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27553/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 231:     cmd = [constants.EXT_DD, "if=%s" % path, "iflag=%s" % DIRECTFLAG,
Line 232:            "of=/dev/null", "bs=%d" % buffersize, "count=1"]
Line 233: 
Line 234:     log.debug("Running %s", utils.list2cmdline(cmd))
Line 235:     p = cpopen.CPopen(cmd, close_fds=True)
Here you're just re-implementing execCmd except for AsyncProc, therefore I think that the correct fix would be trying to not use AsyncProc in execCmd when sync=True.

The performance improvement of that change would be much wider in VDSM.
Line 236:     try:
Line 237:         out, err = p.communicate()
Line 238:         if p.returncode:
Line 239:             log.error("Unable to read file '%s'", path)


-- 
To view, visit http://gerrit.ovirt.org/27553
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ecf1f27d8434aeae672e92ec7adb12e52e419a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list